Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme for models #85

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Conversation

mosesdaudu001
Copy link
Contributor

No description provided.

@mosesdaudu001
Copy link
Contributor Author

Is this template okay?
@juliagsy @Madjid-CH

Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Moses! Thanks for the great work!
Just a few small comments, please let me know when it's ready again, thanks!

AlexNet
===========

AlexNet competed in the ImageNet Large Scale Visual Recognition Challenge on September 30, 2012.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe move the references link here (link at alexnet directly)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

See `this demo <https://unify.ai/demos/examples_and_demos/alexnet_demo.html>`_ for more usage example.


References
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we remove this section?
(not sure if this is available) do we have a citation like the ivy one you added? could you please add/create one in the citation section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@mosesdaudu001 mosesdaudu001 requested a review from juliagsy August 25, 2023 15:48
Copy link
Contributor

@juliagsy juliagsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mosesdaudu001 mosesdaudu001 merged commit 63e17c7 into ivy-llc:main Aug 28, 2023
10 of 12 checks passed
@mosesdaudu001 mosesdaudu001 deleted the readme-for-models branch August 28, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants