-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add torch.tensor.masked_select #28780
Merged
Sam-Armstrong
merged 6 commits into
ivy-llc:main
from
Daniel4078:torch.Tensor.masked_select
Jul 1, 2024
Merged
add torch.tensor.masked_select #28780
Sam-Armstrong
merged 6 commits into
ivy-llc:main
from
Daniel4078:torch.Tensor.masked_select
Jul 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Sam-Armstrong Please check if the new function is added to the correct place. And I want to ask do I need to add a ivy version and a torch backend version of this function as well? |
Sam-Armstrong
requested changes
Jun 30, 2024
Sam-Armstrong
requested changes
Jun 30, 2024
…est to properly produce symmetric positive definite input
… torch.Tensor.masked_select
Sam-Armstrong
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks @Daniel4078 😁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Related Issue
None, add a missing frontend function of torch
Checklist
Socials