Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add torch.tensor.masked_select #28780

Merged
merged 6 commits into from
Jul 1, 2024

Conversation

Daniel4078
Copy link
Contributor

@Daniel4078 Daniel4078 commented Jun 29, 2024

PR Description

Related Issue

None, add a missing frontend function of torch

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@Daniel4078
Copy link
Contributor Author

@Sam-Armstrong Please check if the new function is added to the correct place. And I want to ask do I need to add a ivy version and a torch backend version of this function as well?

@Daniel4078 Daniel4078 marked this pull request as ready for review June 29, 2024 08:10
Jin Wang added 2 commits June 30, 2024 22:38
Copy link
Contributor

@Sam-Armstrong Sam-Armstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @Daniel4078 😁

@Sam-Armstrong Sam-Armstrong merged commit 1e0bad6 into ivy-llc:main Jul 1, 2024
4 of 5 checks passed
@Daniel4078 Daniel4078 deleted the torch.Tensor.masked_select branch July 1, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants