Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix doc_name in update-ci target #143

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

gmantele
Copy link
Contributor

This aims to fix the substitution of the property doc_name in the build and preview GitHub workflows.

See issue raised in ivoa-std/DALI#45

@gmantele gmantele mentioned this pull request Nov 28, 2024
@mbtaylor
Copy link
Member

Thanks @gmantele - we try again: ivoa-std/DALI#46

Copy link
Collaborator

@msdemlei msdemlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I should have caught that before merging. Sorry for being such a slouch when it comes to github CI.

@msdemlei msdemlei merged commit 474d937 into ivoa-std:master Nov 28, 2024
@gmantele
Copy link
Contributor Author

Thanks! I should have caught that before merging. Sorry for being such a slouch when it comes to github CI.

Don't be sorry. I should have check this before pushing these modifications.

@mbtaylor
Copy link
Member

This one worked well enough to enable me to merge the branch that I originally wanted to merge, but following that succesful merge the DALI CI is still failing - for another reason, not finding role_diagram.pdf?

@mbtaylor
Copy link
Member

... but Pat says he's on the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants