-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset sap #14
Dataset sap #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see the expansion of SIA to further data types.
SIA.tex
Outdated
\item Visibility data and event lists are not considered as valid DPTYPES in this version due to complexity of data access functionalities for those dataset types. | ||
\end{itemize} | ||
DsSAP specifies standardID values for each capability, as defined by VODataService \citep{std:VODS11}. DsSAP services may be registered in an IVOA Registry using the SimpleDALRegExt \citep{std:DALREGEXT} extension schema. | ||
\subsection{Changes from SIA-2.0i to DsSAP} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the i on SIA-2.0i intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
SIA.tex
Outdated
|
||
Virtual Observatory access to astronomical images has been available via the SIA-1.0 protocol for over a decade. Many such services have been implemented since 2002, and SIA-1.0 \citep{std:SIAP} was formally standardized as an IVOA Recommendation in 2009. SSA \citep{std:SSA} played a similar role for spectra and also used specific metadata in the query response. SIA-2.0 \citep{std:SIA2} was multi-dimensional and fully integrated with the modern VO architecture and related standards, but restricted to images and data cubes. | ||
DsSAP is an extension of SIA2 to other dataproduct types. It can be seen as a server side parameter based proxy to an ObsTAP service. | ||
IA-2.0 differs from legacy SIA-1.0 in the following aspects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a list of differences missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Have to remove line 59
SIA.tex
Outdated
|
||
Virtual Observatory access to astronomical images has been available via the SIA-1.0 protocol for over a decade. Many such services have been implemented since 2002, and SIA-1.0 \citep{std:SIAP} was formally standardized as an IVOA Recommendation in 2009. SSA \citep{std:SSA} played a similar role for spectra and also used specific metadata in the query response. SIA-2.0 \citep{std:SIA2} was multi-dimensional and fully integrated with the modern VO architecture and related standards, but restricted to images and data cubes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
long lines like this should be broken up to assist readability of the code. This applies to quite a bit of the new content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
SIA.tex
Outdated
|
||
Virtual Observatory access to astronomical images has been available via the SIA-1.0 protocol for over a decade. Many such services have been implemented since 2002, and SIA-1.0 \citep{std:SIAP} was formally standardized as an IVOA Recommendation in 2009. SSA \citep{std:SSA} played a similar role for spectra and also used specific metadata in the query response. SIA-2.0 \citep{std:SIA2} was multi-dimensional and fully integrated with the modern VO architecture and related standards, but restricted to images and data cubes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The std:SSA
and std:SIA2
citations are unresolved and come up as ?
SIA.tex
Outdated
\label{sec:async} | ||
In many cases, datacubes are too large to download and process locally, so the client must be able to perform remote operations. Data discovery could be performed using any discovery protocol (SIA, TAP with ObsCore, etc.). The client must be able to easily figure out if a low level access service is available for a discovered dataset. This could be using a URL provided in the response or by calling an associated DataLink service. Access operations include basic filtering (cut out a subsection of the data), transformations, or other pixel-level operations or even analysis. With current version of the AccessData specification, we will only cover extracting a simple subset of an image or datacube. | ||
In many cases, datasets are too large to download and process locally, so the client must be able to perform remote operations. Data discovery could be performed using any discovery protocol (DsSAP, SIA, TAP with ObsCore, etc.). The client must be able to easily figure out if a low level access service is available for a discovered dataset. This could be using a URL provided in the response or by calling an associated DataLink service. Access operations include basic filtering (cut out a subsection of the data), transformations, or other pixel-level operations or even analysis. With version 1.0 of the SODA 1.0 specification, we will only cover extracting a simple subset of an image or datacube. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 1.0 in SODA 1.0 is repeated and should this be replaced with a citation of SODA 1.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Remove second 1.0
ivoatexmeta.tex
Outdated
@@ -0,0 +1,6 @@ | |||
% GENERATED FILE -- edit this in the Makefile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this file be included in the PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No
.github/workflows/main.yml
Outdated
@@ -0,0 +1,60 @@ | |||
name: Update PDF Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this relate to the existing preview.yml
build script?
@@ -472,7 +443,9 @@ \subsubsection{INSTRUMENT} | |||
The INSTRUMENT parameter is a string-valued parameter that specifies the name of the instrument with which the data was acquired. The value is compared with the instrument\_name from the ObsCore data model. | |||
|
|||
\subsubsection{DPTYPE} | |||
The DPTYPE parameter is a string-valued parameter that specifies the type of data. The value is compared with the dataproduct\_type from the ObsCore data model. For the SIA \{query\} resource, the only values that should be returned for dataproduct\_type are \textit{image} and \textit{cube}, so this parameter can be only really be used to select one of these. | |||
The DPTYPE parameter is a string-valued parameter that specifies the type of data. The value is compared with the dataproduct\_type from the ObsCore data model. In contrast to SIA2.0 which allows only dataproduct\_types \textit{image} and \textit{cube}, all the other dataproduct\_types are allowed, in such a way that we can constrain the service to retrieve visibility data, timeseries and event lists. Using DPTYPE with the "spectrum" value can be considered as an upgrade of the SSA protocol. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include catalogs here? CASDA has downloadable catalogs included in obscore but the dataproduct_type for those must be null according to obscore, which hinders discoverability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tricky point. Please open a new issue for that
Le 23/04/2022 à 02:39, James Dempsey a écrit :
***@***.**** commented on this pull request.
Great to see the expansion of SIA to further data types.
Thanks for reviewing this. I'll answer and fix the bugs ASAP !
… ------------------------------------------------------------------------
In SIA.tex
<#14 (comment)>:
> -\end{itemize}
-While some of the more advanced capabilities for dynamic access to multi-dimensional images are still under development, the initial specification provides the capability to discover and download multi-dimensional image datasets via a service interface consistent with current VO standards
-
-\subsection{Current and Future support}
- These are the list of changes which will be considered in a later version of this protocol (SIA-2.1):
-\begin{itemize}
- \item The protocol should support a detailed {metadata} capability. In the current design, this capability will take a single parameter with an identifier (typically a publisher dataset identifier from a data discovery response) and return a document with detailed metadata about the dataset. The primary usage is to drill-down to the detailed metadata after discovery
- \item The standardID for the {metadata} capability will probably be : ivo://ivoa.net/std/SIA\#metadata-2.1
- \item The parameter language should be extended to support case-insensitivity, wildcards, and pattern recognition.
- \item The DALI UPLOAD facility will be defined in order to allow queries based on values stored in a file.
- \item The protocol will also support an option for virtual data discovery. With this option, controlled by usage of an optional parameter, the query can force the discovery of virtual datasets with best matching to the input parameter constraints
- \item COLLECTION and FACILITY currently provide query parameters provide selection on service defined set of strings. It would be good to define standardized lists of those at IVOA level for next version.
- \item Visibility data and event lists are not considered as valid DPTYPES in this version due to complexity of data access functionalities for those dataset types.
-\end{itemize}
+DsSAP specifies standardID values for each capability, as defined by VODataService \citep{std:VODS11}. DsSAP services may be registered in an IVOA Registry using the SimpleDALRegExt \citep{std:DALREGEXT} extension schema.
+\subsection{Changes from SIA-2.0i to DsSAP}
Is the i on SIA-2.0i intended?
------------------------------------------------------------------------
In SIA.tex
<#14 (comment)>:
>
+Virtual Observatory access to astronomical images has been available via the SIA-1.0 protocol for over a decade. Many such services have been implemented since 2002, and SIA-1.0 \citep{std:SIAP} was formally standardized as an IVOA Recommendation in 2009. SSA \citep{std:SSA} played a similar role for spectra and also used specific metadata in the query response. SIA-2.0 \citep{std:SIA2} was multi-dimensional and fully integrated with the modern VO architecture and related standards, but restricted to images and data cubes.
+DsSAP is an extension of SIA2 to other dataproduct types. It can be seen as a server side parameter based proxy to an ObsTAP service.
+IA-2.0 differs from legacy SIA-1.0 in the following aspects:
Is there a list of differences missing here?
------------------------------------------------------------------------
In SIA.tex
<#14 (comment)>:
>
+Virtual Observatory access to astronomical images has been available via the SIA-1.0 protocol for over a decade. Many such services have been implemented since 2002, and SIA-1.0 \citep{std:SIAP} was formally standardized as an IVOA Recommendation in 2009. SSA \citep{std:SSA} played a similar role for spectra and also used specific metadata in the query response. SIA-2.0 \citep{std:SIA2} was multi-dimensional and fully integrated with the modern VO architecture and related standards, but restricted to images and data cubes.
long lines like this should be broken up to assist readability of the
code. This applies to quite a bit of the new content.
------------------------------------------------------------------------
In SIA.tex
<#14 (comment)>:
>
+Virtual Observatory access to astronomical images has been available via the SIA-1.0 protocol for over a decade. Many such services have been implemented since 2002, and SIA-1.0 \citep{std:SIAP} was formally standardized as an IVOA Recommendation in 2009. SSA \citep{std:SSA} played a similar role for spectra and also used specific metadata in the query response. SIA-2.0 \citep{std:SIA2} was multi-dimensional and fully integrated with the modern VO architecture and related standards, but restricted to images and data cubes.
The |std:SSA| and |std:SIA2| citations are unresolved and come up as |?|
------------------------------------------------------------------------
In SIA.tex
<#14 (comment)>:
> \label{sec:async}
-In many cases, datacubes are too large to download and process locally, so the client must be able to perform remote operations. Data discovery could be performed using any discovery protocol (SIA, TAP with ObsCore, etc.). The client must be able to easily figure out if a low level access service is available for a discovered dataset. This could be using a URL provided in the response or by calling an associated DataLink service. Access operations include basic filtering (cut out a subsection of the data), transformations, or other pixel-level operations or even analysis. With current version of the AccessData specification, we will only cover extracting a simple subset of an image or datacube.
+In many cases, datasets are too large to download and process locally, so the client must be able to perform remote operations. Data discovery could be performed using any discovery protocol (DsSAP, SIA, TAP with ObsCore, etc.). The client must be able to easily figure out if a low level access service is available for a discovered dataset. This could be using a URL provided in the response or by calling an associated DataLink service. Access operations include basic filtering (cut out a subsection of the data), transformations, or other pixel-level operations or even analysis. With version 1.0 of the SODA 1.0 specification, we will only cover extracting a simple subset of an image or datacube.
The 1.0 in SODA 1.0 is repeated and should this be replaced with a
citation of SODA 1.0?
------------------------------------------------------------------------
In ivoatexmeta.tex
<#14 (comment)>:
> @@ -0,0 +1,6 @@
+% GENERATED FILE -- edit this in the Makefile
Should this file be included in the PR?
------------------------------------------------------------------------
In .github/workflows/main.yml
<#14 (comment)>:
> @@ -0,0 +1,60 @@
+name: Update PDF Preview
How does this relate to the existing |preview.yml| build script?
------------------------------------------------------------------------
In SIA.tex
<#14 (comment)>:
> @@ -472,7 +443,9 @@ \subsubsection{INSTRUMENT}
The INSTRUMENT parameter is a string-valued parameter that specifies the name of the instrument with which the data was acquired. The value is compared with the instrument\_name from the ObsCore data model.
\subsubsection{DPTYPE}
-The DPTYPE parameter is a string-valued parameter that specifies the type of data. The value is compared with the dataproduct\_type from the ObsCore data model. For the SIA \{query\} resource, the only values that should be returned for dataproduct\_type are \textit{image} and \textit{cube}, so this parameter can be only really be used to select one of these.
+The DPTYPE parameter is a string-valued parameter that specifies the type of data. The value is compared with the dataproduct\_type from the ObsCore data model. In contrast to SIA2.0 which allows only dataproduct\_types \textit{image} and \textit{cube}, all the other dataproduct\_types are allowed, in such a way that we can constrain the service to retrieve visibility data, timeseries and event lists. Using DPTYPE with the "spectrum" value can be considered as an upgrade of the SSA protocol.
Should we include catalogs here? CASDA has downloadable catalogs
included in obscore but the dataproduct_type for those must be null
according to obscore, which hinders discoverability.
—
Reply to this email directly, view it on GitHub
<#14 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMP5LTDTPZ43OPC2P7ZU7ELVGNBD7ANCNFSM5UDNEZEA>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Changes will no more be provided by bunches of little PRs |
Major change to change the scope from images/cubes to all datasets. Solves issue #10