Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modif of spatial parameters + modif of registry details + suppression of todo + suppression of typo in table #71

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

Bonnarel
Copy link
Collaborator

No description provided.

@Bonnarel Bonnarel changed the title suppression of todo + suppreession of typo in table suppression of todo + suppression of typo in table Nov 14, 2024
@Bonnarel Bonnarel changed the title suppression of todo + suppression of typo in table Modif of spatial parameters + modif of registry details + suppression of todo + suppression of typo in table Nov 14, 2024
loumir
loumir previously approved these changes Nov 15, 2024
@loumir
Copy link
Collaborator

loumir commented Nov 15, 2024

approuved changes

Copy link
Collaborator

@loumir loumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for subsection

@@ -268,16 +267,18 @@ \subsection{s\_fov}
%mid value of the spectral range
receiver nominal wavelength and D coincides with the telescope diameter (SD case) or the largest diameter of the array antennae or telescopes (interferometric case).
In interferometry, the correlator can also restrict the fov depending on the trade-off set to build the signal.

Nominal wavelength SHOULD be taken as the mid value of the spectral range except if data providers have good reasons to propose another value which should be documented in the FIELD DESCRIPTION tag in that case.
Copy link
Collaborator

@loumir loumir Nov 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the nominal wavelength is defined in the data collection should be clarified if we want to query and compare on s_resolution or s_fov .
we would have to add a new item in the TAP radio extension to mention it , named em_nominal_wavelength for instance , with
em_nominal_wavelength , in meters, with ucd =em.wl.effective .
Is it necessary ?
Or can we rely instead , in the radio extension table, on the min and max values for all features depending on the spectral range : s_fov, s_largest_max scale and s_resolution ???

Copy link
Collaborator Author

@Bonnarel Bonnarel Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the nominal wavelength is defined in the data collection should be clarified if we want to query and compare on s_resolution or s_fov . we would have to add a new item in the TAP radio extension to mention it , named em_nominal_wavelength for instance , with em_nominal_wavelength , in meters, with ucd =em.wl.effective . Is it necessary ? Or can we rely instead , in the radio extension table, on the min and max values for all features depending on the spectral range : s_fov, s_largest_max scale and s_resolution ???
?

For sure, nominal wavelength is used to estimate nominal s_fov and nominal s_resolution. But although I think queries on these nominal s_fov and s_resolution are useful for coarse grain discovery , I don't think we have demands for discovery using this nominal wavelength. So is it useful to add it in the list of attributes ? Thoughts ?

explicitly write the formula for s_fov_Min/max and s_resolution_min/max
loumir
loumir previously approved these changes Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants