-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ci #45
Merged
Merged
Update ci #45
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a576e0a
update ivoatex
mbtaylor f6c7eab
update CI by running make update-ci
mbtaylor 961f4a6
update ivoatex to master
mbtaylor 390b851
update ivoatex to fix-pdftk
mbtaylor 3d5f9a6
update CI by running make update-ci
mbtaylor 0cb9742
update ivoatex to commit on master
mbtaylor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,47 @@ | ||
name: CI build of the standard | ||
# This file generated from a template file maintained in the ivoatex repository. | ||
# To create and install it into a project repository, do: | ||
# make github-preview | ||
# git commit | ||
# git push | ||
# | ||
name: Check the IVOA document | ||
|
||
on: | ||
env: | ||
doc_name: DALI | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
steps: | ||
- uses: actions/checkout@v1 | ||
|
||
- name: Checkout the repository | ||
uses: actions/checkout@v4 | ||
with: | ||
submodules: true | ||
|
||
- name: Setup dependencies | ||
run: | | ||
sudo apt update | ||
sudo apt install texlive-latex-base texlive-latex-recommended texlive-latex-extra texlive-fonts-recommended xsltproc ghostscript cm-super librsvg2-bin inkscape | ||
|
||
sudo apt install texlive-latex-base texlive-latex-recommended \ | ||
texlive-latex-extra texlive-fonts-recommended \ | ||
pdftk xsltproc latexmk cm-super | ||
|
||
- name: Build the document | ||
run: make role_diagram.pdf biblio forcetex | ||
run: make | ||
|
||
- name: Check the output | ||
run: | | ||
test -f DALI.pdf | ||
test -f DALI.bbl | ||
|
||
- uses: actions/upload-artifact@v1 | ||
test -f ${{ env.doc_name }}.pdf | ||
test -f ${{ env.doc_name }}.bbl | ||
|
||
- name: Keep the PDF artefact | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: DALI.pdf Preview | ||
path: DALI.pdf | ||
name: PDF Preview | ||
path: ${{ env.doc_name }}.pdf |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule ivoatex
updated
24 files
+49 −6 | Makefile | |
+1 −1 | Makefile.template | |
+14 −3 | README.rst | |
+121 −0 | aas_macros.tex | |
+2 −15 | archdiag-full.xml | |
+81 −12 | docrepo.bib | |
+1 −0 | document.template | |
+5 −3 | github_workflow_build.yml.template | |
+27 −27 | github_workflow_preview.yml.template | |
+123 −35 | ivoa.bst | |
+6 −3 | ivoa.cls | |
+21 −0 | regressiontest/README.rst | |
+570 −0 | regressiontest/run-regression.py | |
+4 −3 | submission.py | |
+9 −0 | suggest-bibupgrade.py | |
+4 −0 | test/Makefile | |
+17 −0 | test/test-ivoa-bst-urls.aux | |
+90 −0 | test/test-ivoa-bst-urls.bib | |
+44 −0 | test/test-ivoa-bst-urls.good | |
+19 −0 | test/test-ivoa-bst-urls.sh | |
+18 −0 | tth_C/UPDATING | |
+144 −144 | tth_C/tth.c | |
+5 −0 | tthdefs.tex | |
+20 −2 | update_generated.py |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doc_name
isn't set here, so later in L38 the${{ env.doc_name }}-draft.pdf
substitution becomes-draft.pdf
. It "passed" (i.e. didn't run) in the PR because this workflow will only run on pushes to themain
branch.Is
doc_name
supposed to be set dynamically somewhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. The
update-ci
target does not set this field in the CI configuration file. It was already done like that before. But sure, maybe we can do better by doing that automatically with this Makefile target.Sorry again for this issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looking now at the Makefile code, we are already doing this automatically when
DOCNAME
is set in the Makefile. But the problem is due to the spaces I have added betweendoc_name
and the:
. What a stupid mistake...sorry, I push a new PullRequest to fix this. I hope this time it will be OK.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See PullRequest ivoa-std/ivoatex#143 for a fix