Proof of concept: optional features for Invidious through optional shards #5075
+45
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syeopite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a proof of concept not really a serious proposal
This PR allows for Invidious to support optional features through optional extensions. These extensions are essentially just
glorified shards that are automatically imported (the only human interaction needed is to define it in
shards.yml) during compile-time due to them having a set name and initialization structure.This PR removes the Reddit comment functionality from Invidious directly and transfers it to this optional extension shard https://github.com/syeopite/extendious-reddit-comments here.
Only
/api/v1/comments/:id?source=reddithas been migrated though. Kemal's middleware logic doesn't allow for editing the response from the route handler before it is sent to the client.The way its middleware logic are ordered also doesn't give much flexibility for extensions...