Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Java 17 and 21 #72

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Adapt to Java 17 and 21 #72

merged 11 commits into from
Jul 9, 2024

Conversation

kaklakariada
Copy link
Contributor

@kaklakariada kaklakariada commented Jul 7, 2024

Fixes #68

@kaklakariada kaklakariada requested review from redcatbear and ckunki July 7, 2024 13:06
public interface Capturable
{
/**
* Activate capturing
*/
public void capture();
void capture();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this? I always found this notation inconsistent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sonar complains about this. Interface methods are public by default.

Copy link

sonarqubecloud bot commented Jul 9, 2024

@kaklakariada kaklakariada merged commit 065aaa1 into main Jul 9, 2024
7 checks passed
@kaklakariada kaklakariada deleted the adapt-project-to-java-17-&-21 branch July 9, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with Java 17 fails due to missing Javadoc comments
3 participants