Dual-targeting netcoreapp3.1 #84
Conversation
|
@jehhynes if you'd like to become a maintainer so you can continue updating the nuget, I'll add you. Since I don't use Harvest any longer it's a bit difficult to maintain. |
|
Ok, that works. How do you create the nuget package? It looks like you have
some kind of templating in place.
…On Thu, Nov 4, 2021 at 10:11 AM Joel Potter ***@***.***> wrote:
@jehhynes <https://github.com/jehhynes> if you'd like to become a
maintainer so you can continue updating the nuget, I'll add you.
Since I don't use Harvest any longer it's a bit difficult to maintain.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#84 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7DKCWYXYSPQBG5XPYYEALUKKPDJANCNFSM5HLN6Q7A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Update the version, then build, then run https://github.com/ithielnor/harvest.net/blob/master/.pack/publish-nuget.ps1 It requires that you have your nuget key in your dropbox like Griddly. |
|
It looks like you have this setup so it doesn't require separate packages, which is good. But you'll still want to increment the version. I don't think the changes are breaking, so patch version? |
|
Not like I would expect a big outrage on this in 2021, but technically going from .NET 4.5 to 4.5.2 is a breaking change. My vote would be for a major version bump. |
|
Actually, it already was targeting 4.5.2:
|
|
@jehhynes Ah sorry, you're right, my eyes caught one of the NuGet packages going from net45 to net452 when scanning the diff. |
No description provided.