Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA QR Codes #961

Merged
merged 2 commits into from
May 26, 2024
Merged

2FA QR Codes #961

merged 2 commits into from
May 26, 2024

Conversation

wrongecho
Copy link
Collaborator

@wrongecho wrongecho commented May 26, 2024

Move away from the Google Charts API for generating QR codes as this is currently broken and not a security best practice.

Note: Generating images locally requires the 'gd' extension for PHP. Docs and install script has been updated.

Move away from the Google Charts API for generating QR codes as this is currently broken and not a security best practice.
@wrongecho
Copy link
Collaborator Author

Test these changes at: https://qrcodefix961.pr-review.itflow.org
(automatic message)

Move away from the Google Charts API for generating QR codes as this is currently broken and not a security best practice.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
15.7% Duplication on New Code

See analysis details on SonarCloud

@wrongecho wrongecho merged commit f103797 into itflow-org:master May 26, 2024
2 checks passed
@wrongecho wrongecho deleted the qr-code-fix branch May 26, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant