Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client_logins uri limit with ellipsis #958

Merged
merged 4 commits into from
May 17, 2024

Conversation

ssteeltm
Copy link
Contributor

limits long uri that may break lines in table

example:
image

it put ellipsis on the displayed long uri

ssteeltm added 2 commits May 16, 2024 10:48
limits long uri that may break lines in table
@johnnyq
Copy link
Collaborator

johnnyq commented May 17, 2024

nice work and deff needed for those long URIs however we have a PHP function for this already in the functions.php

function truncate($text, $chars)
{
    if (strlen($text) <= $chars) {
        return $text;
    }
    $text = $text . " ";
    $text = substr($text, 0, $chars);
    $lastSpacePos = strrpos($text, ' ');
    if ($lastSpacePos !== false) {
        $text = substr($text, 0, $lastSpacePos);
    }
    return $text . "...";
}

Please update your pull request to use the function, and thank you for your commitment to ITFlow

Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnnyq
Copy link
Collaborator

johnnyq commented May 17, 2024

awesome looks good reeling in

@johnnyq johnnyq merged commit 579482c into itflow-org:master May 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants