-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2.0.0 Make POST actions use functions that API V2 can use #918
Conversation
Inventory
This draft PR shows the work to attempt to make all actions in post.php occur via functions. This enables easier management of a CRUD API
Fix Database name
Sonar Cleanups
Test these changes at: https://0200functionalizing918.pr-review.itflow.org |
…2.0.0-functionalizing
…itflow into 0.2.0.0-functionalizing
Hey @o-psi there quite a bit to go through here. It will take me a few weeks to test and go through properly. We already have an API in place, although it could use additional end points as you stated. Also I don't want to change the POST code into functions. I want to keep the code style the way it is. So if you remove all those POST functions ill review the code again. |
Also Can we put each small feature into its own pull request in the future as well. There no way my brain can not process this in a timely manor as i'm also working on core code duties. I'm not able to work efficiently or effectively this way. For example Credits will have it own Pull Request. Update Ticket Statuses to use a function etc |
@johnnyq I think this may be our fork in the road. For the version of this project I am maintaining, I will definitely use functions instead of hard coding it all. I think it's a bit shortsighted, as a more modular codebase with less duplication will be easiest to maintain. In the end I was only using this project because it was what was best for our company, at this point I think what is best for my company is to hard fork. Many thanks to all the work you have put into this package so far! |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
{WIP}
This should simplify the codebase with a branch in mind, and makes the API more maintainable.