Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.0.0 Make POST actions use functions that API V2 can use #918

Closed
wants to merge 54 commits into from

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Mar 20, 2024

{WIP}

This should simplify the codebase with a branch in mind, and makes the API more maintainable.

@wrongecho
Copy link
Collaborator

Test these changes at: https://0200functionalizing918.pr-review.itflow.org
(automatic message)

@o-psi o-psi changed the title 0.2.0.0 functionalizing 0.2.0.0 Make POST actions use functions that API V2 can use Mar 20, 2024
@johnnyq
Copy link
Collaborator

johnnyq commented Mar 22, 2024

Hey @o-psi there quite a bit to go through here. It will take me a few weeks to test and go through properly. We already have an API in place, although it could use additional end points as you stated. Also I don't want to change the POST code into functions. I want to keep the code style the way it is. So if you remove all those POST functions ill review the code again.

@johnnyq
Copy link
Collaborator

johnnyq commented Mar 22, 2024

Also Can we put each small feature into its own pull request in the future as well. There no way my brain can not process this in a timely manor as i'm also working on core code duties. I'm not able to work efficiently or effectively this way.

For example Credits will have it own Pull Request. Update Ticket Statuses to use a function etc

@o-psi
Copy link
Contributor Author

o-psi commented Mar 22, 2024

@johnnyq I think this may be our fork in the road.

For the version of this project I am maintaining, I will definitely use functions instead of hard coding it all.

I think it's a bit shortsighted, as a more modular codebase with less duplication will be easiest to maintain. In the end I was only using this project because it was what was best for our company, at this point I think what is best for my company is to hard fork.

Many thanks to all the work you have put into this package so far!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ B)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@o-psi o-psi closed this Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants