0.2.0.0 functionalizing #910
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inventory
This draft PR shows the work to attempt to make all actions in post.php occur via functions. This enables easier management of a CRUD API
|
Test these changes at: https://0200functionalizing910.pr-review.itflow.org |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function tryAPIKey($api_key_secret) { | ||
| global $mysqli, $session_ip, $session_user_agent; | ||
|
|
||
| $row = mysqli_fetch_array(mysqli_query($mysqli,"SELECT * FROM api_keys WHERE api_key_secret = '$api_key_secret'")); |
Check failure
Code scanning / SonarCloud
Database queries should not be vulnerable to injection attacks High
Fix Database name
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworking of post.php logic where most actions occur via functions.
This way we can manipulate those functions for the API.
Goal is an easier to maintain codebase as our logic grows more complicated, and to ease api development.
I am building a NinjaOne integration tool (distinct from ITFlow, dw) and realized that the API is a bit cobbled together, and very cumbersome to add to.