-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain expiration dates #888
Conversation
wrongecho
commented
Feb 22, 2024
- Update logic in post when adding/editing a domain to better account for null values
- Update logic in cron domain refresher to account for null values
- Prevent cron domain refresher getting stuck on a single domain
- Exclude domains with no expiration date from the cron nightly renewal alerts
- Update logic in post when adding/editing a domain to better account for null values - Update logic in cron domain refresher to account for null values - Prevent cron domain refresher getting stuck on a single domain - Exclude domains with no expiration date from the cron nightly renewal alerts
Test these changes at: https://dnsexpirynullfix888.pr-review.itflow.org |
Quality Gate passedIssues Measures |
Pardon me for not having too much insight into either PHP or ITFlow, but shouldnt there be an ALTER TABLE statement somewhere? And changes to database initializaiton? |
@NickyM I thought the same, but it turns out we actually already allow NULL for the domain expiry field! Line 504 in 31184f0
I think the issue was the code previously was trying to add it as a variable which was then enclosed in quotes in the SQL statement, so it was treated as a string rather than an actual null. |
Just realised that the error message that I got yesterday, surelay states 'NULL' and not NULL for the error. :)
The domain adding/editing works fine for me then. |
@wrongecho @NickyM Things are working fine for me too. I feel confident to reel in. |
It's truly amazing how tiny, insignificant errors can make or break big features haha! Thanks again for your help on this - has been a thorn in my side since it was first added! :) |