Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.8.4 (Recurring client sidebar) #882

Closed
wants to merge 21 commits into from
Closed

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Feb 15, 2024

No description provided.

@o-psi o-psi changed the title 0.1.8.4 0.1.8.4 (Recurring client sidebar) Feb 15, 2024
@wrongecho
Copy link
Collaborator

Test these changes at: https://0184882.pr-review.itflow.org
(automatic message)

@johnnyq
Copy link
Collaborator

johnnyq commented Feb 15, 2024

Nice work on all this,
And just brain storming here but
I was thinking that we should probably have a separate table called event_attendees

attendee_id
attendee_name
attendee_email
attendee_notes
attendee_declined_at
attendee_accepted_at
attendee_created_at
attendee_updated_at
attendee_contact_id --- If one of the contacts is selected then reference the contact_id for linkage later on maybe in reporting or history tracking etc otherwise this can happily default to 0
attendee_event_id

This is so each event can have multiple attendees. I didn't add a archived_at as it doesn't matter if its deleted

Let me know your thoughts and or if there is anything I missed or you feel should be different

Wanted to also see if you wanted to take a stab at it since your focusing on calendar events at the moment?

@o-psi
Copy link
Contributor Author

o-psi commented Feb 15, 2024

i like the idea, But we are not using events any, so I have yet to figure them out haha.

Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues

Measures
3 Security Hotspots
No data about Coverage
31.9% Duplication on New Code

See analysis details on SonarCloud

@o-psi o-psi marked this pull request as ready for review February 15, 2024 22:17
@o-psi o-psi closed this Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants