Update settings_backup.php #852
Conversation
Backup and restore from the backup menu. Add backups folder into the uploads, so the backup path will be uploads/backups https://www.veed.io/view/5bc75a75-9af6-4fc4-a462-6a161c8b9c23?panel=share
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
settings_backup.php
Outdated
| // Implement delete selected logic here | ||
| if (isset($_POST['selectedBackups'])) { | ||
| foreach ($_POST['selectedBackups'] as $selectedBackup) { | ||
| unlink($backupFolder . $selectedBackup); |
Check failure
Code scanning / SonarCloud
I/O function calls should not be vulnerable to path injection attacks High
There was a problem hiding this comment.
have no idea what this means
settings_backup.php
Outdated
| $selectedBackup = $_POST['proceed-restore']; | ||
|
|
||
| $sqlFile = $backupFolder . $selectedBackup; | ||
| $sqlContent = file_get_contents($sqlFile); |
Check failure
Code scanning / SonarCloud
I/O function calls should not be vulnerable to path injection attacks High
There was a problem hiding this comment.
again, not sure what this means
|
Test these changes at: https://patch14852.pr-review.itflow.org |
|
auch, not sure about the security there, but if one of you guys can have a look at it, please do so, thank you! |
|
Hey! It's been a while :) I can't actually get this to load on PR Review? |
|
you`ll need to create backups folder inside uploads so path will be uploads/backups. test it locally first :D |
|
Ah okay. Is there a way we can do that within the page itself, possibly with Also, is |
|
not sure the best approach ( folder structure and security wise), that's why i've asked for second opinion :D i've done the script locally, test it and works. now, going from this, sure, we can make it much better, at least we have a base to work from. still need to figure out the restore from file aspect, which should be another modal uploading file and restore script to handle that file. But with baby steps, and all the great minds, we`ll get there :D |
create backups folder in /uploads folder if not exists create backups and restore
|
Backup and restore from the backup menu. Add backups folder into the uploads, so the backup path will be uploads/backups
https://www.veed.io/view/5bc75a75-9af6-4fc4-a462-6a161c8b9c23?panel=share