Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in variable name and add condition for invoice status #841

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Fix typo in variable name and add condition for invoice status #841

merged 2 commits into from
Dec 29, 2023

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Dec 22, 2023

This pull request fixes a typo in the variable name "invoice_satus" and adds a condition to check if the invoice status is "Draft" before displaying it as an option in the dropdown menu for the ticket add to invoice modal.

@wrongecho
Copy link
Collaborator

Test these changes at: https://ticketaddtoinvoicedrafts841.pr-review.itflow.org
(automatic message)

@johnnyq
Copy link
Collaborator

johnnyq commented Dec 22, 2023

Excellent catch, there is a conflict that needs resolved before we can merge.

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johnnyq johnnyq merged commit ae44414 into itflow-org:master Dec 29, 2023
2 checks passed
@o-psi o-psi deleted the ticket-add-to-invoice-drafts branch January 10, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants