Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonar Cleanups #836

Closed
wants to merge 8 commits into from
Closed

Sonar Cleanups #836

wants to merge 8 commits into from

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Dec 20, 2023

This pull request includes cleanups suggested by Sonar Cloud. It addresses code quality issues and improves the overall maintainability of the codebase.

@wrongecho
Copy link
Collaborator

Test these changes at: https://sonarcleanup836.pr-review.itflow.org
(automatic message)

@johnnyq
Copy link
Collaborator

johnnyq commented Dec 21, 2023

Oh this is a big one,ill need time to review it, but im not too keen on what it does with the table columns. Although the code is shorter. Sometimes more code explains the code better. Let remove the table column change for now, and ill continue to review.

@o-psi
Copy link
Contributor Author

o-psi commented Dec 21, 2023

I understand it explains the code better, but it's so repetitive that its very much going to be a maintainability issue. What about dedicated comment blocks explaining how the code works, or a function that can do it when given an array of column names?

I don't think the code is very intuitive with how it's done currently, but that's my 0.02

@johnnyq
Copy link
Collaborator

johnnyq commented Dec 21, 2023

Lets revisit this one after 1.0, right now im in process of heavily testing critical functionality this is going to take me a week or so here. Basically were supposed to be at a code freeze on Dec 20th for ITFlow

Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

51 New issues
2 Security Hotspots
No data about Coverage
7.2% Duplication on New Code

See analysis details on SonarCloud

@o-psi
Copy link
Contributor Author

o-psi commented Dec 22, 2023

I was thinking we wanted this done by 1.0, will hold off.

@o-psi o-psi closed this Dec 22, 2023
@o-psi o-psi deleted the sonar-cleanup branch December 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants