Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting Recurring and Quotes #769

Merged
merged 8 commits into from
Oct 16, 2023
Merged

Sorting Recurring and Quotes #769

merged 8 commits into from
Oct 16, 2023

Conversation

o-psi
Copy link
Contributor

@o-psi o-psi commented Oct 16, 2023

This PR adds sorting for recurring and quotes, in the same manner as #768

@wrongecho
Copy link
Collaborator

Test these changes at: https://othersorts769.pr-review.itflow.org
(automatic message)

@johnnyq
Copy link
Collaborator

johnnyq commented Oct 16, 2023

nice! looks like there are some conflicts that need resolved in post/invoice.php
Will pull in once resolved, but other than that it looks great @o-psi

@o-psi
Copy link
Contributor Author

o-psi commented Oct 16, 2023

I think I did it!! This git stuff seems needlessly complex haha.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@johnnyq johnnyq merged commit 9818c57 into itflow-org:master Oct 16, 2023
3 checks passed
@johnnyq
Copy link
Collaborator

johnnyq commented Oct 16, 2023

Hello @o-psi I fixed a few things after we pulled this in, as DB updates was broken this was because tables: quote_items and recurring_items tables do not exist. They all reference just invoice_items.
Also the DB version 0.8.10 did not want to update from 0.8.9 so we changed it to DB Version 0.9.0 and that fixed the issue.
We also dumped the DB Structure for new installs.

@johnnyq
Copy link
Collaborator

johnnyq commented Oct 16, 2023

See this git commit for the details
fba1115

@johnnyq
Copy link
Collaborator

johnnyq commented Oct 16, 2023

Recurring Invoice and Quotes are not displaying the order arrows on recurring or quotes see here

Quote: shows order numbers just no arrows
image

Recurring Invoice: Not showing any sorting arrow button or numbers
image

@o-psi
Copy link
Contributor Author

o-psi commented Oct 16, 2023

They are under hamburger menu modals. Planning to do the same to the invoice screen.

@johnnyq
Copy link
Collaborator

johnnyq commented Oct 16, 2023

ohhh nice! =] Okay I like that idea! Good work

@o-psi o-psi deleted the other-sorts branch October 17, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants