Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contact small edits #735

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Contact small edits #735

merged 2 commits into from
Oct 8, 2023

Conversation

wrongecho
Copy link
Collaborator

@wrongecho wrongecho commented Oct 7, 2023 •
edited
Loading

  • Adjust behaviour when selecting "Send user e-mail with login details?" (show reset link OR prompt user to change password if tech set one)
  • Email wording change (remove ITFlow reference and replace with MSP name)
  • Show contact PIN in the portal
  • Add confirm dialogue to anonymise and archive
  • Bump password min length to 8 (and enforce on tech side)
  • Bugfix undefined send_email value

@wrongecho
Contact small edits
2633820 
- Adjust behaviour when selecting "Send user e-mail with login details?" (show reset link OR prompt user to change password if tech set one)
- Email wording change (remove ITFlow reference and replace with MSP name)
- Show contact PIN in the portal
- Bump password min length to 8 (and enforce on tech side)
- Bugfix undefined send_email value
@wrongecho wrongecho marked this pull request as draft October 7, 2023 19:44
@wrongecho
Copy link
Collaborator Author

Test these changes at: https://contactdetails735.pr-review.itflow.org
(automatic message)

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
21.0% 21.0% Duplication

@wrongecho wrongecho marked this pull request as ready for review October 8, 2023 06:59
@wrongecho wrongecho mentioned this pull request Oct 8, 2023
Open
@johnnyq johnnyq merged commit dcd17c7 into itflow-org:master Oct 8, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrongecho @johnnyq