All asset report - custom columns #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new version of the all asset report allowing custom columns to be used
|
|
Test these changes at: https://assetsreportcustomcolumns1012.pr-review.itflow.org |
|
Nice I can deff use this for further inspiration and integrate it into our little Listing Framework. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new version of the all asset report allowing custom columns to be used.
This is not overly pretty or intuitive but it gets the job done for now. Hopefully we can take inspiration from this and roll something similar out across the app.
As long as you're happy there are no security issues, can we at least merge and then add to the reports menu to address some of the queries around how to get asset data out of ITFlow for reporting? We can always make the UI nicer later :).