Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: slimTitleLink #343

Merged
merged 3 commits into from
Apr 8, 2024
Merged

feat: slimTitleLink #343

merged 3 commits into from
Apr 8, 2024

Conversation

stefanozanelliunitn
Copy link
Contributor

Aggiunta proprietà link relativa a slimTitle in ItHeaderComponent (visualizzazione desktop)

Descrizione

Nel componte ItHeader è presente la possibilità di indicare la proprietà slimTitle, ma il link associato è sempre indicato con il valore '#'.
Aggiunta proprietà, con default '#', per aggiungere slimTitleLink associato all'etichetta. Il target del link è stato impostato a '_blank' se il contenuto è diverso da '#'.

Checklist

Aggiunta proprietà  link relativa a slimTitle in ItHeaderComponent (visualizzazione desktop)
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-angular-kit ✅ Ready (Inspect) Visit Preview Apr 4, 2024 6:45am

@astagi
Copy link
Member

astagi commented Mar 28, 2024

Good catch @stefanozanelliunitn thank you!

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.54%. Comparing base (c97d377) to head (d8d94cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   45.50%   45.54%   +0.04%     
==========================================
  Files          71       71              
  Lines        1156     1157       +1     
  Branches      247      247              
==========================================
+ Hits          526      527       +1     
  Misses        604      604              
  Partials       26       26              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi
Copy link
Member

astagi commented Apr 4, 2024

Hi @stefanozanelliunitn did you add a new component on this branch?

@stefanozanelliunitn
Copy link
Contributor Author

Erroneamente il commit del componente era finito su main, ho applicato il revert del commit

@astagi
Copy link
Member

astagi commented Apr 4, 2024

Grazie @stefanozanelliunitn

@astagi
Copy link
Member

astagi commented Apr 8, 2024

@stefanozanelliunitn se vuoi riportare il commit del componente Timeline su un altro branch fai pure così possiamo inserirlo nella nuova release! Grazie mille!

@astagi astagi merged commit d147d2a into italia:main Apr 8, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Apr 8, 2024

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants