P4 2879 Cortex - Phantom-Snap Page Rendering #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Reviewer
When this is complete, you should approve the PR via github.
For the Reviewee
P4 2879 Cortex - Phantom-Snap Page Rendering
Summary
Created Dockerfile that contains PhantomJS and runs a uvicorn/fastapi api entrypoint, built on python:3.7-buster
# /docker created files:
Created docker-compose.yml # Build and run container via docker-compose
Modified /phantom_snap/settings.py # Update to contain default settings for Cortex Renderer
Created /phantom_snap/cortex_renderer.py # Cortex Renderer (similar to lambda_renderer)
Release Note
Created Dockerfile that runs phantom-snap page rendering via direct request or through cortex_renderer.py
Breaking Changes
None.
Quality Assurance
You have gathered the following items:
Given all of the items above, you have updated your Application ORT at the following locations:
Testing and Verification
Steps to test your application for someone not familiar with it. Required.
Do this:
In the phantom-snap directory, run:
Look for this.
Clean up with this command