- Register health check through _config.php as YML was not registering

- Change date formate to SS3

_config.php

@@ -0,0 +1,5 @@
+<?php
+
+use LittleGiant\SpinDB\Health\BackupCheck;
+
+EnvironmentCheckSuite::register('check', BackupCheck::class, "Is the database backup saving to S3 daily?");

_config/environmentcheck.yml

@@ -5,7 +5,3 @@ EnvironmentCheckSuite:
   registered_suites:
     health:
       - spindb
-  registered_checks:
-    spindb:
-      definition: 'LittleGiant\SpinDB\Health\BackupCheck'
-      title: 'Is the database backup saving to S3 daily?'

composer.json

@@ -1,6 +1,5 @@
 {
     "name": "littlegiant/silverstripe-spindb",
-    "type": "silverstripe-vendormodule",
     "license": "BSD-3-Clause",
     "description": "Backup DB periodically and backup to AWS S3 storage with rotation",
     "require": {
@@ -18,12 +17,7 @@
     ],
     "extra": {
         "branch-alias": {
-            "dev-master": "1.x-dev"
-        }
-    },
-    "autoload": {
-        "psr-4": {
-            "LittleGiant\\SpinDB\\": "src/"
+            "dev-ss3": "dev-ss3.x-compat"
         }
     },
     "scripts": {

src/Configuration/RotateConfig.php

@@ -34,8 +34,8 @@ protected static function getFixedArgs(): array
     public static function getCurrentArgs(): array
     {
         return [
-            'date' => SS_Datetime::now()->Format('y-MM-dd'),
-            'time' => SS_Datetime::now()->Format('HH.mm.ss'),
+            'date' => SS_Datetime::now()->Format('Y-m-d'),
+            'time' => SS_Datetime::now()->Format('H.i.s'),
         ];
     }
 
@@ -110,6 +110,7 @@ public static function parse($path): ?array
             return null;
         }
 
+
         // Return array of matched parts
         $result = [];
         foreach ($patterns as $name => $value) {

src/Storage/RotateStorage.php

@@ -4,7 +4,9 @@
 
 use Aws\Result;
 use Aws\S3\S3Client;
+use Debug;
 use Exception;
+use Injector;
 use LittleGiant\SpinDB\Configuration\RotateConfig;
 use Object;
 
@@ -66,7 +68,9 @@ public function getFiles()
         ]);
         $files = [];
         $objects = $objects->get('Contents');
-        if ($objects) {
+
+        if (!empty($objects)) {
+
             foreach ($objects as $object) {
                 $parts = RotateConfig::parse($object['Key']);
                 if ($parts) {

src/Storage/S3ClientFactory.php

@@ -5,6 +5,7 @@
 use Aws\Credentials\Credentials;
 use Aws\S3\S3Client;
 use LittleGiant\SpinDB\Configuration\RotateConfig;
+use SilverStripe\Framework\Injector\Factory;
 
 class S3ClientFactory implements Factory
 {