feat(tests): move e2e tests for consultation-portal to their app #17008
+1,048
−171
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,6 +23,7 @@ | |
| **/*.log | ||
| **/tmp/ | ||
| **/temp/ | ||
| **/.next/ | ||
|
|
||
| # Outputs | ||
| **/dist/ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| ARG NODE_IMAGE_TAG=20.15.0-alpine3.20 | ||
|
|
||
| # Stage 1: Install dependencies | ||
| FROM node:${NODE_IMAGE_TAG} AS dependencies | ||
|
|
||
| # Set working directory | ||
| WORKDIR /app | ||
|
|
||
| # Install Python3 and build tools | ||
| RUN apk add --no-cache python3 py3-pip make g++ && ln -sf /usr/bin/python3 /usr/bin/python | ||
|
|
||
| # Copy only package management files | ||
| COPY package.json yarn.lock ./ | ||
| COPY .yarn/ .yarn | ||
| COPY .yarnrc.yml .yarnrc.yml | ||
| COPY ./apps/native/app/package.json ./apps/native/app/package.json | ||
|
|
||
| # Install dependencies | ||
| RUN --mount=type=cache,target=/app/.yarn/cache \ | ||
| yarn install --immutable && yarn cache clean | ||
|
|
||
| # Stage 2: Final runtime image | ||
| FROM node:${NODE_IMAGE_TAG} | ||
|
|
||
| # Install Python (runtime requirement if needed) | ||
| RUN apk add --no-cache python3 py3-pip && ln -sf /usr/bin/python3 /usr/bin/python | ||
|
|
||
| # Enable Corepack and Yarn 3.2.3 | ||
| RUN corepack enable && corepack prepare [email protected] --activate | ||
|
|
||
| # Set working directory | ||
| WORKDIR /app | ||
|
|
||
| # Copy from dependencies stage | ||
| COPY --from=dependencies /app/node_modules ./node_modules | ||
| COPY --from=dependencies /app/yarn.lock ./yarn.lock | ||
| COPY --from=dependencies /app/.yarn/ ./.yarn | ||
| COPY --from=dependencies /app/.yarnrc.yml ./.yarnrc.yml | ||
|
|
||
| # Copy source code and necessary configuration files | ||
| COPY ./apps ./apps | ||
| COPY ./libs ./libs | ||
| COPY ./infra ./infra | ||
| COPY ./tools ./tools | ||
| COPY ./tsconfig.base.json ./ | ||
| COPY ./tsconfig.shared.json ./ | ||
| COPY ./package.json ./ | ||
|
|
||
|
Comment on lines
+23
to
+48
There was a problem hiding this comment. Add security best practices Consider enhancing the security of the final image:
# Copy source code and necessary configuration files
COPY ./apps ./apps
COPY ./libs ./libs
COPY ./infra ./infra
COPY ./tools ./tools
COPY ./tsconfig.base.json ./
COPY ./tsconfig.shared.json ./
COPY ./package.json ./
+
+# Create non-root user
+RUN addgroup -S appgroup && adduser -S appuser -G appgroup
+RUN chown -R appuser:appgroup /app
+USER appuser
+
+# Add healthcheck
+HEALTHCHECK --interval=30s --timeout=3s \
+ CMD wget --no-verbose --tries=1 --spider http://localhost:4200/samradsgatt || exit 1
|
||
| # Verify Yarn version in runtime container | ||
| RUN yarn --version | ||
|
|
||
| # Default command to run the app | ||
| CMD ["yarn", "nx", "serve"] | ||
|
|
||
| # ARG NODE_IMAGE_TAG=20.15.0-alpine3.20 | ||
| # FROM node:${NODE_IMAGE_TAG} AS build | ||
|
|
||
| # WORKDIR /app | ||
|
|
||
| # # Install build dependencies | ||
| # RUN apk add --no-cache \ | ||
| # python3 \ | ||
| # py3-pip \ | ||
| # make \ | ||
| # g++ | ||
|
|
||
| # # Set Python symlink | ||
| # RUN ln -sf /usr/bin/python3 /usr/bin/python | ||
|
|
||
| # # Install dependencies | ||
| # COPY package.json yarn.lock ./ | ||
| # COPY .yarn/ .yarn | ||
| # COPY .yarnrc.yml .yarnrc.yml | ||
| # COPY ./apps/native/app/package.json ./apps/native/app/package.json | ||
|
|
||
| # # Run yarn install | ||
| # RUN --mount=type=cache,target=/app/.yarn/cache \ | ||
| # yarn install --immutable | ||
|
|
||
| # # Copy source code | ||
| # COPY . . | ||
|
|
||
| # # Verify installation | ||
| # RUN yarn nx --version | ||
|
|
||
| # # Set default entrypoint | ||
| # CMD ["yarn", "nx"] | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Remove commented-out code
Instead of keeping the commented-out test job configuration, consider removing it entirely since it's tracked in version control. If this code needs to be referenced later, it can be found in the git history.
🧰 Tools
🪛 actionlint (1.7.4)
190-190: label "ec2-runners" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2022", "windows-2019", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-22.04", "ubuntu-20.04", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "macos-12-xl", "macos-12-xlarge", "macos-12-large", "macos-12", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file
(runner-label)