feat(rental-agreement): Project structure & minimal functionality #16214
+5,447
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eement-application
This reverts commit fda88fb.
…eement-application
…eement-application
…eement-application
…sland.is into rental-agreement-application
…ardcoded text to message translation text.
…eement-application
WalkthroughThe changes in this pull request introduce a new application type, Changes
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Datadog ReportAll test runs ✅ 98 Total Test Services: 0 Failed, 90 Passed Test ServicesThis report shows up to 10 services
🔻 Code Coverage Decreases vs Default Branch (2) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16214 +/- ##
==========================================
- Coverage 35.76% 35.67% -0.10%
==========================================
Files 6931 6926 -5
Lines 147977 148223 +246
Branches 42173 42283 +110
==========================================
- Hits 52931 52872 -59
- Misses 95046 95351 +305
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 40 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
addi
changed the title
…eement-application
…eement-application
* Add logo. Add summary section and init custom component to form. * Update summary custom component * Summary updates * Add all viable data from fields to summary * Fix conflict from merge * Fix lint error for relative import * Update summary styling * Update summary component structure * Update summary. Add Security deposit amount. Add phone fileds with country codes. * Fix lint errors
…eement-application
…eement-application
…sland.is into rental-agreement-application
…eement-application
* Add logo. Add summary section and init custom component to form. * Update summary custom component * Summary updates * Add all viable data from fields to summary * Fix conflict from merge * Fix lint error for relative import * Update summary styling * Update summary component structure * Update summary. Add Security deposit amount. Add phone fileds with country codes. * Fix lint errors * Add special groups to summary. * Update summary
* Add logo. Add summary section and init custom component to form. * Update summary custom component * Summary updates * Add all viable data from fields to summary * Fix conflict from merge * Fix lint error for relative import * Update summary styling * Update summary component structure * Update summary. Add Security deposit amount. Add phone fileds with country codes. * Fix lint errors * Add special groups to summary. * Update summary * Updates from PR comments
…eement-application
…sland.is into rental-agreement-application
…eement-application
…eement-application
…eement-application
…eement-application
…17147) * Update and validate landlord info inputs. * NationalId validation update * Landlord info schema update * Update landlord details rendering of name and nationalId * Update validation for landlord and tenant information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rental-agreement project structure & minimal functionality
This is pretty much just wireframe code around a new application system form.
Locked behind a feature flag created in ConfigCat and added to @island.is/feature-flags package as per instructions in github docs.
Why
We want to get this code in so we can start developing in a better workflow, small PRs, QA and such.
Checklist:
Summary by CodeRabbit
New Features
Configuration Updates
Enhancements