Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy SampleCount when making a copy of FilamentView #7072

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Copy SampleCount when making a copy of FilamentView #7072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0932cdf
Copy SampleCount when making a copy of FilamentView
patrikhuber Nov 23, 2024
76f12f2
Updated CHANGELOG.md
patrikhuber Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
## Main
- Fix MSAA sample count not being copied when FilamentView is copied
- Fix TriangleMesh::SamplePointsUniformly and TriangleMesh::SamplePointsPoissonDisk now sampling colors from mesh if available (PR #6842)
- Fix TriangleMesh::SamplePointsUniformly not sampling triangle meshes uniformly (PR #6653)
- Fix tensor based TSDF integration example.
Expand Down
1 change: 1 addition & 0 deletions cpp/open3d/visualization/rendering/filament/FilamentView.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ void FilamentView::CopySettingsFrom(const FilamentView& other) {
if (other.color_grading_) {
view_->setColorGrading(other.color_grading_);
}
view_->setSampleCount(other.view_->getSampleCount());
auto ao_options = other.view_->getAmbientOcclusionOptions();
view_->setAmbientOcclusionOptions(ao_options);
auto aa_mode = other.view_->getAntiAliasing();
Expand Down
Loading