Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix render to depth image on Apple Retina displays #7001

Merged
merged 3 commits into from
Oct 21, 2024
Merged

fix render to depth image on Apple Retina displays #7001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bcd9d3
fix render to depth image on Apple Retina displays
rxba Oct 6, 2024
8e00824
update CHANGELOG.md
rxba Oct 6, 2024
13547d0
Merge branch 'main' into fix_depth_rendering_macos
ssheorey Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
- Support lowercase types when reading PCD files (PR #6930)
- Fix visualization/draw ICP example and add warnings (PR #6933)
- Fix alpha shape reconstruction if alpha too small for point scale (PR #6998)
- Fix render to depth image on Apple Retina displays (PR #7001)

## 0.13

Expand Down
4 changes: 4 additions & 0 deletions cpp/open3d/visualization/rendering/filament/FilamentRenderToBuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,10 @@ void FilamentRenderToBuffer::CopySettings(const View* view) {
// overhead and the depth buffer is discarded when post-processing is
// enabled so the returned image is all 0s.
view_->ConfigureForColorPicking();
// Set shadowing to true as there is a pixel coordinate scaling
// issue on Apple Retina displays that results in quarter size depth
// images if shadowing is disabled.
view_->SetShadowing(true, View::ShadowType::kPCF);
}
}

Expand Down
Loading