Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy examples for building user projects with Open3D to Open3D repo #6884

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

ssheorey
Copy link
Member

Earlier example location:

Copying them into the main repo to reduce maintenance overhead and ensure they are up-to-date.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Earlier example location:

https://github.com/intel-isl/open3d-cmake-find-package
https://github.com/isl-org/open3d-cmake-external-project

Copying them into the main repo to reduce maintenance overhead and ensure they are up to date.
Copy link

update-docs bot commented Jul 22, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested review from yxlao, benjaminum and errissa July 23, 2024 16:00
@ssheorey ssheorey merged commit 9f03592 into main Jul 25, 2024
42 of 45 checks passed
@ssheorey ssheorey deleted the ss/cmake-examples branch July 25, 2024 22:34
@ssheorey
Copy link
Member Author

Merged after CI passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant