Skip to content

Commit

Permalink
Windows CI out of disk space workaround (#6281)
Browse files Browse the repository at this point in the history
Windows CI (CUDA, Debug) is failing due to "out of disk space". This bypasses this check and updates the docs, allowing devel Python wheels and C++ binaries to be available.

Misc:
-    Style fix
-    CPU rendering tutorial (for Nvidia/ AMD drivers)
  • Loading branch information
ssheorey authored Jul 25, 2023
1 parent ff6fa56 commit d569978
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 5 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,9 @@ jobs:
# no need to run on Windows
runs-on: ubuntu-latest
if: ${{ github.ref == 'refs/heads/master' }}
needs: [build-wheel, windows]
# temp workaround for Windows CUDA Debug CI out of space. Still update docs.
# needs: [build-wheel, windows]
needs: [build-wheel]
steps:
- name: GCloud CLI auth
uses: google-github-actions/auth@v1
Expand Down
3 changes: 2 additions & 1 deletion cpp/open3d/geometry/TriangleMesh.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1634,7 +1634,8 @@ std::shared_ptr<TriangleMesh> TriangleMesh::SelectByIndex(
output->triangles_.push_back(
Eigen::Vector3i(nvidx0, nvidx1, nvidx2));
if (has_triangle_material_ids) {
output->triangle_material_ids_.push_back(triangle_material_ids_[tidx]);
output->triangle_material_ids_.push_back(
triangle_material_ids_[tidx]);
}
if (has_triangle_normals) {
output->triangle_normals_.push_back(triangle_normals_[tidx]);
Expand Down
22 changes: 19 additions & 3 deletions docs/tutorial/visualization/cpu_rendering.rst
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,24 @@ The method for enabling interactive CPU rendering depends on your system:
them installed is not sufficient. You can check the drivers in use with the
``glxinfo`` command.

2. **You use Nvidia or AMD drivers or old Mesa drivers (< v20.2).** We provide
2. **You use Nvidia or AMD drivers, but your OS comes with recent Mesa drivers (>= v20.2).**
Install Mesa drivers if they are not installed in your system (e.g. `sudo apt install libglx0-mesa`
in Ubuntu). Preload the Mesa driver library before running any Open3D application requiring CPU rendering.
For example:

.. code:: bash
export LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libGLX_mesa.so.0
Open3D
Or with Python code:

.. code:: bash
export LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libGLX_mesa.so.0
python examples/python/visualization/draw.py
3. **Your OS has old Mesa drivers (< v20.2).** We provide
the Mesa software rendering library binary for download `here
<https://github.com/isl-org/open3d_downloads/releases/download/mesa-libgl/mesa_libGL_22.0.tar.xz>`__.
This is automatically downloaded to
Expand All @@ -115,5 +132,4 @@ The method for enabling interactive CPU rendering depends on your system:

.. code:: bash
LD_PRELOAD=$HOME/.local/lib/libGL.so.1.5.0 python
examples/python/visualization/draw.py
LD_PRELOAD=$HOME/.local/lib/libGL.so.1.5.0 python examples/python/visualization/draw.py

0 comments on commit d569978

Please sign in to comment.