Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#2): add buffer time to reload the extension #3

Merged
merged 2 commits into from
Oct 28, 2023
Merged

fix(#2): add buffer time to reload the extension #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea252ea
fix(#2): add buffer time to reload the extension
isaurssaurav Oct 28, 2023
4e4a8b0
refactor(#2): code
isaurssaurav Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
dist
dist
.vscode
8 changes: 5 additions & 3 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,11 @@ const hotReloadExtension = (options: hotReloadExtensionOptions): Plugin => {
chalkLogger.red('Load extension to browser...');
return;
}
// TODO BUG: when user triggers watch before previous build is completed, the extension crashes
ws?.send(Message.FILE_CHANGE);
if (log) chalkLogger.green('Extension Reloaded...');

setTimeout(() => {
ws?.send(Message.FILE_CHANGE);
if (log) chalkLogger.green('Extension Reloaded...');
}, 1000);
}
};
};
Expand Down