feat(#10): side panel HMR support #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
! One note: I am not sure what is the behaviour here when you specify 2 paths though. |
Tested locally on the extension I'm developing, working as expected! |
isaurssaurav
changed the title
Comment on lines
+36
to
+38
| chalkLogger.red( | ||
| 'Target file missing! Please, specify either `backgroundPath` or `sidepanelPath` in the plugin options' | ||
| ); |
There was a problem hiding this comment.
Info: can we use warn logger here?
| @@ -26,16 +27,30 @@ const hotReloadExtension = (options: hotReloadExtensionOptions): Plugin => { | |||
| return { | |||
| name: PLUGIN_NAME, | |||
| async transform(code: string, id: string) { | |||
| console.log('🚀 ~ transform ~ id:', id); | |||
There was a problem hiding this comment.
Please remove this log. It will flood the console.
|
Can you update the readme file? and also add this too example project? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #10
Thanks to @danielsussa for the code!