Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: add options to filter and compare benchmarks #320

Closed
wants to merge 3 commits into from

Conversation

lukekarrys
Copy link

@lukekarrys lukekarrys commented Oct 4, 2024

Built on top of #319.

This adds options to the benchmarks via util.parseArgs which allow for:

  • filtering benchmark cases. This was helpful in benchmarking refactor: move to native fs.promises #314 because there was no reason to benchmark old or system rimraf. By default all benchmarks are included by individual ones can be picked with --cases or omitted with --omit-cases. For refactor: move to native fs.promises #314, I ran node benchmark/index.js -osystem -oold -oparallel which uses the short option -o to omit old, system, and parallel benchmarks.
  • Saving and comparing benchmark runs. --save will save the benchmark results and options to a file benchmark-${Date.now()} and then --compare=benchmark-1728082932414.json can be used later. This will add old mean and % +/- columns to the table output comparing the current run with the file read from --compare.

@lukekarrys lukekarrys changed the title lk/compare benchmarks benchmark: add options to filter and compare benchmarks Oct 4, 2024
@lukekarrys
Copy link
Author

Closing in favor of #322

@lukekarrys lukekarrys closed this Oct 10, 2024
@lukekarrys lukekarrys deleted the lk/compare-benchmarks branch October 10, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant