Stop allocating so much while formatting. #100
Conversation
| @@ -173,3 +184,21 @@ pub enum FormatText { | |||
| pub struct FormatUnit { | |||
| pub text: FormatText, | |||
| } | |||
|
|
|||
|
|
|||
| #[doc(hidden)] | |||
There was a problem hiding this comment.
Not necessary if the entire mod is not public, no?
|
|
||
| } | ||
|
|
||
| pub fn display_with<'a>(format: &'a Format, |
There was a problem hiding this comment.
Ideally this would be a method on Format, but I realize that this is not possible due to the wish to constrain the public API.
You could also think about it as a constructor of FormatDisplay but I'm not sure if that's an internal API we want.
There was a problem hiding this comment.
I turned it into a method of a private trait. I'm not entirely sure that the trait is appropriately generic, but given that it currently has a single use, I don't think that is a big deal.
| Method => fmt.write_fmt(format_args!("{}", req.method)), | ||
| URI => fmt.write_fmt(format_args!("{}", req.url)), | ||
| Status => match res.status { | ||
| Some(status) => fmt.write_fmt(format_args!("{}", status)), |
There was a problem hiding this comment.
You can replace this with status.fmt I think. Same goes for similar branches.
|
Updated. |
|
Thanks! |
|
Oh, feel free to add yourself to the authors array in Cargo.toml though I'm not sure if that's how we're tracking contributors now. Otherwise I'll release a new version ASAP |
See #41.
This is a breaking change, as it cleans up the public API by hiding the details of formatting.