Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding PUT to assets and some refactoring #59

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

adding PUT to assets and some refactoring #59

wants to merge 10 commits into from

Conversation

cmcgeeney-ir
Copy link
Contributor

These two scripts seem pretty similar so decided to try and refactor a bit to reuse code

Changes include:

  • Creation of helper_functions.py
  • Creation of constants.py
  • Creation of mappers.py
  • Adding in logging to these files
  • Refactoring security classifications file to use these changes
  • Refactoring assets to use these changes
  • Adding in PUT functionality to assets if the asset already exists with the same name in the destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cmcgeeney-ir