Dell OS10: Fix test cases 33-vrf-common-ospf and 34- by redistributing imported OSPF routes too #1571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbemmel
changed the title
* Fix reference_bandwidth to be taken from the vdata, not global ospf
|
@ssasso You know way more about OS10 than I do. Are these changes OK? |
Not to put words in his mouth, but #1135 (comment) explicitly includes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might be related to #1135
Fixes both 33-vrf-common-ospf and 34-vrf-common-mixed integration test cases
Technically this flag is only required if there are multiple VRFs running OSPF and they import from each other - but I think it's safe to enable whenever OSPF is used in VRFs
Note: Also fixes reference_bandwidth attribute