fix: allocate new slices for component nodes #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvagg
force-pushed
the
rvagg/alloc-nodes
branch
from
e7b6fef
to
a65a17b
Compare
rvagg
added a commit
to application-research/autoretrieve
that referenced
this pull request
Nov 29, 2022
rvagg
force-pushed
the
rvagg/alloc-nodes
branch
from
a65a17b
to
ec3149a
Compare
rvagg
added a commit
to application-research/autoretrieve
that referenced
this pull request
Nov 29, 2022
willscott
approved these changes
Nov 29, 2022
rvagg
added a commit
to application-research/autoretrieve
that referenced
this pull request
Nov 29, 2022
|
We didn't end up needing this - it wasn't the root cause of the problem we were trying to solve, instead it was a growing backlog of messages that weren't getting processed, so the memory allocations being held were legitimately in a queue. But, this change may be worth pursuing so I'm not going to close it out. Instead, some benchmarks would be good to see what the impact may be from this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: application-research/autoretrieve#142 (comment)