Support object peerid format in difference util #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
After upgrading to new libp2p (0.40) we noticed that we have serious performance problems (battery drain on mobile). We've found out that we're using new PeerId format in which we have objects instead of strings, I think it has occurred across multiple packages in orbitdb too, where conversion id to string was the solution, but this issue is not critical and I suppose others also experience this after migrating to new libp2p and ipfs but they are not aware, however it affects performance, because _onPeerConnected and exchangeHeads is called on every emitJoinAndLeaves tick, so the app is getting really busy.
This is the behavior I see:
new values Set(1) { PeerId(Qmaec9tu8vWtY89W3PY4sh2wAoSV2b7jdmooVtSqaAb6PW) } old values Set(1) { PeerId(Qmaec9tu8vWtY89W3PY4sh2wAoSV2b7jdmooVtSqaAb6PW) } difference Set(1) { PeerId(Qmaec9tu8vWtY89W3PY4sh2wAoSV2b7jdmooVtSqaAb6PW) }
After few small changes I made:
new values Set(1) { PeerId(Qmaec9tu8vWtY89W3PY4sh2wAoSV2b7jdmooVtSqaAb6PW) } old values Set(1) { PeerId(Qmaec9tu8vWtY89W3PY4sh2wAoSV2b7jdmooVtSqaAb6PW) } difference Set(0) {}