Fix coverity issues (5) #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55910: Unintended sign extension in oc_notify_observers_delayed 55594: Unintended sign extension in oc_notify_observers_delayed_ms
|
🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed. ℹ️ To verify your latest change (9ab778d), label this PR with |
Danielius1922
force-pushed
the
adam/bugfix/467-coverity-fixes-5
branch
2 times, most recently
from
62f05e1 to
3148d4a
Compare
Open
76 tasks
jkralik
reviewed
Jul 7, 2023
Danielius1922
force-pushed
the
adam/bugfix/467-coverity-fixes-5
branch
from
3148d4a to
7c6dee1
Compare
jkralik
reviewed
Jul 7, 2023
jkralik
reviewed
Jul 7, 2023
jkralik
reviewed
Jul 7, 2023
jkralik
reviewed
Jul 7, 2023
ocf-conformance-test-tool
bot
removed
the
OCF Conformance Testing
Danielius1922
force-pushed
the
adam/bugfix/467-coverity-fixes-5
branch
from
a5bfa62 to
180e712
Compare
55558, 55868: Out-of-bounds access in coap_remove_observer_by_resource
To ensure compatibility with platforms where long is a 32-bit integer, the unsigned long oc_clock_seconds() function has been replaced with uint64_t oc_clock_seconds_v1(). This change allows the representation of UNIX Epoch times beyond the year 2038, which would otherwise be limited by the 32-bit integer size of long. Fixes coverity issue: 55774: Use of 32-bit time_t
55781: Unchecked return value in obt_check_owned (obt.c) 55864: Overflowed return value in oc_sec_certs_md_algorithm_is_allowed (oc_certs.c)
55937, 55938: Unintentional integer overflow in tcp_waiting_session_check (linux/tcp_session.c) 55942: Unintended sign extension in tcp_check_expiring_sessions (linux/tcp_session.c) 55943: Unintentional integer overflow in tcp_check_expiring_sessions (linux/tcp_session.c)
Danielius1922
force-pushed
the
adam/bugfix/467-coverity-fixes-5
branch
from
180e712 to
833d333
Compare
|
Kudos, SonarCloud Quality Gate passed! |
jkralik
approved these changes
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467