Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues in oc_cred.c and oc_roles.c #469

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Fix issues in oc_cred.c and oc_roles.c #469

merged 1 commit into from
Jul 19, 2023

Conversation

Danielius1922
Copy link
Member

@Danielius1922 Danielius1922 commented Jun 16, 2023 •
edited by jkralik
Loading

Fixes #467

@ocf-conformance-test-tool
Copy link

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (208dbef), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch 5 times, most recently from d0752d4 to ff99eee Compare June 22, 2023 11:25
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch from ff99eee to c6b1917 Compare June 27, 2023 16:07
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Jun 27, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch from c6b1917 to 0d448a7 Compare June 29, 2023 15:19
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Jun 29, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch from 0d448a7 to 87d95c1 Compare June 29, 2023 15:28
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Jun 29, 2023
@SiMet SiMet added OCF Conformance Testing OCF Conformance Testing required and removed OCF Conformance Testing OCF Conformance Testing required labels Jun 30, 2023
@SiMet
Copy link
Collaborator

SiMet commented Jun 30, 2023

@Danielius1922 jenkins is fixed. It's already testing this PR

@Danielius1922
Copy link
Member Author

@Danielius1922 jenkins is fixed. It's already testing this PR

Thank you! I've planned to write to you after finishing some other work, but you beat me to it!

@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch from 87d95c1 to 68ad9a1 Compare July 13, 2023 09:47
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Jul 13, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch 7 times, most recently from b8fbe60 to d34bd80 Compare July 17, 2023 15:23
@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Jul 17, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch from d34bd80 to ba4ace9 Compare July 17, 2023 15:59
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Jul 17, 2023
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch 4 times, most recently from 9ad3173 to bad07b3 Compare July 18, 2023 07:10
@Danielius1922
Refactor oc_cred.c and oc_roles.c
5a602c9 
- refactor certificate generation and other parts of code with
issues reported by SonarCloud
- add unit tests
@Danielius1922 Danielius1922 force-pushed the adam/bugfix/467-coverity-fixes branch from bad07b3 to 5a602c9 Compare July 18, 2023 07:32
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

72.0% 72.0% Coverage
1.9% 1.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Danielius1922 Danielius1922 added OCF Conformance Testing OCF Conformance Testing required and removed OCF Conformance Testing OCF Conformance Testing required labels Jul 18, 2023
@Danielius1922
Copy link
Member Author

@SiMet Something broke with the CTT job again, could you please check it? Thanks.

(I wonder what happened, it was working like clockwork yesterday.)

@SiMet
Copy link
Collaborator

SiMet commented Jul 18, 2023

@SiMet Something broke with the CTT job again, could you please check it? Thanks.

(I wonder what happened, it was working like clockwork yesterday.)

Hi @Danielius1922 ,

We've got internal error with our gitlab system. It's under maintainanace.
We need to fix it. Sorry for inconvience.

@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Jul 18, 2023
@Danielius1922 Danielius1922 marked this pull request as ready for review July 19, 2023 07:55
@Danielius1922 Danielius1922 merged commit a62f772 into master Jul 19, 2023
@Danielius1922 Danielius1922 deleted the adam/bugfix/467-coverity-fixes branch July 19, 2023 07:56
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
OCF Conformance Testing OCF Conformance Testing required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Coverity issues
2 participants
@Danielius1922 @SiMet