Remove unnecessary _oc_signal_event_loop calls

iotivity · Sep 4, 2023 · 277aab3 · 277aab3
1 parent 92f6a3b
commit 277aab3
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 10 deletions.
diff --git a/api/cloud/oc_cloud_manager.c b/api/cloud/oc_cloud_manager.c
@@ -170,23 +170,20 @@ cloud_start_process(oc_cloud_context_t *ctx)
       ctx->store.cps == OC_CPS_READYTOREGISTER) {
     oc_reset_delayed_callback(ctx, cloud_manager_register_async,
                               g_retry_timeout[0]);
-    goto finish;
+    return;
   }
   if ((ctx->store.status & OC_CLOUD_REGISTERED) != 0) {
     if (cloud_context_has_permanent_access_token(ctx)) {
       oc_reset_delayed_callback(ctx, cloud_manager_login_async,
                                 g_retry_timeout[0]);
-      goto finish;
+      return;
     }
     if (cloud_context_has_refresh_token(ctx)) {
       oc_reset_delayed_callback(ctx, cloud_manager_refresh_token_async,
                                 g_retry_timeout[0]);
-      goto finish;
+      return;
     }
   }
-
-finish:
-  _oc_signal_event_loop();
 }
 
 static uint64_t

diff --git a/api/cloud/oc_cloud_store.c b/api/cloud/oc_cloud_store.c
@@ -182,7 +182,6 @@ cloud_store_dump_async(const oc_cloud_store_t *store)
   // so this void* cast which drops const is safe
   oc_remove_delayed_callback((void *)store, cloud_store_dump_handler);
   oc_set_delayed_callback((void *)store, cloud_store_dump_handler, 0);
-  _oc_signal_event_loop();
 }
 
 static bool

diff --git a/api/oc_buffer.c b/api/oc_buffer.c
@@ -229,7 +229,6 @@ oc_send_message(oc_message_t *message)
                       message) == OC_PROCESS_ERR_FULL) {
     oc_message_unref(message);
   }
-  _oc_signal_event_loop();
 }
 
 #ifdef OC_HAS_FEATURE_TCP_ASYNC_CONNECT
@@ -241,7 +240,6 @@ oc_tcp_connect_session(oc_tcp_on_connect_event_t *event)
                       event) == OC_PROCESS_ERR_FULL) {
     oc_tcp_on_connect_event_free(event);
   }
-  _oc_signal_event_loop();
 }
 #endif /* OC_HAS_FEATURE_TCP_ASYNC_CONNECT */
 

diff --git a/api/oc_network_events_internal.h b/api/oc_network_events_internal.h
@@ -39,6 +39,8 @@ OC_PROCESS_NAME(oc_network_events);
  * @brief network receive event
  *
  * @param message the network message
+ *
+ * @note called from network thread
  */
 void oc_network_receive_event(oc_message_t *message);
 
@@ -47,6 +49,8 @@ void oc_network_receive_event(oc_message_t *message);
  * @brief network TCP connect event
  *
  * @param event the TCP on connect event
+ *
+ * @note called from network thread
  */
 void oc_network_tcp_connect_event(oc_tcp_on_connect_event_t *event);
 #endif /* OC_HAS_FEATURE_TCP_ASYNC_CONNECT */

diff --git a/messaging/coap/observe.c b/messaging/coap/observe.c
@@ -1212,7 +1212,6 @@ static void
 dispatch_process_batch_observers(void)
 {
   oc_reset_delayed_callback(NULL, &process_batch_observers_async, 0);
-  _oc_signal_event_loop();
 }
 
 static void