[refactor] Introduce action radio to broadcast #4497
Merged
+175
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
envestcc
requested review from
CoderZhi,
dustinxie,
Liuhaai and
a team
as code owners
CoderZhi
reviewed
Nov 21, 2024
Comment on lines
+87
to
+89
| if err != nil { | ||
| log.L().Warn("Failed to broadcast SendAction request.", zap.Error(err), zap.String("actionHash", hex.EncodeToString(hash[:]))) | ||
| } |
There was a problem hiding this comment.
nvm, it is an interface implementation
CoderZhi
approved these changes
Nov 26, 2024
dustinxie
reviewed
Nov 26, 2024
api/action_radio_test.go
Outdated
| }, | ||
| 0) | ||
| r.NoError(radio.Start()) | ||
| defer radio.Stop() |
There was a problem hiding this comment.
defer func() {
r.NoError(radio.Stop())
}()
dustinxie
approved these changes
Nov 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ActionRadiocomponent is introduced in this update to broadcast actions received in the API node to the network.This is a pre-PR aimed at facilitating the implement of action retry mechanism next
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: