Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4470 #4472

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix #4470 #4472

wants to merge 3 commits into from

Conversation

simonerom
Copy link
Member

@simonerom simonerom commented Oct 31, 2024

Description

Show the account address in 0x + io1 format upon creation with ioctl account createadd

~ bin/ioctl account createadd test-address
#test-address: Set password

#test-address: Enter password again

New account "test-address" is created.
Please keep your password safe, or you will lose access to your private key.

Account address:
0xd324cd3033e594f278a7c494dc2b33c3df9e0560 (io16vjv6vpnuk20y798cj2dc2enc00euptqmxaxh3)

Fixes #(issue)
#4470

Type of change

  • [] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • [] Manually built and tested

Copy link

sonarcloud bot commented Oct 31, 2024

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (436e4d1) to head (92efe4c).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4472      +/-   ##
==========================================
- Coverage   74.83%   74.25%   -0.58%     
==========================================
  Files         378      380       +2     
  Lines       31624    31941     +317     
==========================================
+ Hits        23666    23719      +53     
- Misses       6747     7001     +254     
- Partials     1211     1221      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simonerom simonerom added the ioctl label Nov 1, 2024
Copy link

sonarcloud bot commented Dec 10, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants