Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move plugins and theme to src #1578

Merged
merged 7 commits into from
May 28, 2024
Merged

Move plugins and theme to src #1578

merged 7 commits into from
May 28, 2024

Conversation

jlvandenhout
Copy link
Contributor

@jlvandenhout jlvandenhout commented May 28, 2024 •
edited
Loading

Description of change

  • Moved plugins and theme components into src and fix imports and dependencies.
  • Removed tutorial logic from the CLI as it is now only internal.
  • Removed now obsolete build steps from the scripts and CI.

Links to any relevant issues

#1544

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@jlvandenhout jlvandenhout requested a review from Dr-Electron May 28, 2024 08:58
@jlvandenhout jlvandenhout self-assigned this May 28, 2024
@jlvandenhout jlvandenhout mentioned this pull request May 28, 2024
Closed
4 tasks
@Dr-Electron Dr-Electron marked this pull request as draft May 28, 2024 13:33
@Dr-Electron Dr-Electron added the Argos Enable visual regression check label May 28, 2024
@Dr-Electron Dr-Electron marked this pull request as ready for review May 28, 2024 13:33
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: adc0699

✅ Preview: https://iota-wiki-8rqq24oqg-iota1.vercel.app

@argos-ci Argos CI
Copy link

argos-ci bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 49 changed May 28, 2024, 1:54 PM

Dr-Electron
Dr-Electron approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@Dr-Electron Dr-Electron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and Argos 🔥

@Dr-Electron Dr-Electron merged commit 8e75bf4 into main May 28, 2024
10 checks passed
@Dr-Electron Dr-Electron deleted the feat/move-plugins-and-theme branch May 28, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Electron Dr-Electron Dr-Electron approved these changes

Assignees

@jlvandenhout jlvandenhout

Labels
Argos Enable visual regression check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlvandenhout @Dr-Electron