Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update core contract refs #1538

Merged
merged 5 commits into from
May 31, 2024
Merged

Update core contract refs #1538

merged 5 commits into from
May 31, 2024

Conversation

Dr-Electron
Copy link
Collaborator

Description of change

Updated the docs to iotaledger/wasp#3336

Links to any relevant issues

Fixes #1535

Type of change

  • Documentation Enhancement

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work

@Dr-Electron
Copy link
Collaborator Author

One open question. Does nativeTokenCreate have a return value? If so it is missing in https://github.com/iotaledger/wasp/blob/af9f243b453fd5e031c1f680893f3bfd86e287ce/packages/wasmvm/wasmlib/interfaces/coreaccounts.yaml#L49C3-L49C20

@Dr-Electron Dr-Electron requested a review from lmoe April 26, 2024 14:42
@Dr-Electron Dr-Electron marked this pull request as ready for review April 26, 2024 14:51
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: c9a7b2f

✅ Preview: https://iota-wiki-c097axw95-iota1.vercel.app

@Dr-Electron Dr-Electron marked this pull request as draft May 6, 2024 08:00
@Dr-Electron Dr-Electron marked this pull request as ready for review May 6, 2024 08:00
Copy link
Contributor

github-actions bot commented May 6, 2024

This pull request has been deployed to Vercel.

Latest commit: 6543765

✅ Preview: https://iota-wiki-fnmbh4aia-iota1.vercel.app

@Dr-Electron Dr-Electron marked this pull request as draft May 6, 2024 08:14
Copy link

@lmoe lmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM :)

@Dr-Electron Dr-Electron marked this pull request as ready for review May 31, 2024 22:34
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 725c6d0

✅ Preview: https://iota-wiki-qeqa8jcjn-iota1.vercel.app

@Dr-Electron Dr-Electron merged commit 8b24e90 into main May 31, 2024
10 checks passed
@Dr-Electron Dr-Electron deleted the docs/wasp-ref branch May 31, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update token docs for wasp
2 participants