Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history 
Co-authored-by: Eike Haß <[email protected]>
  • Loading branch information
@Dr-Electron @eike-hass
Dr-Electron and eike-hass authored Sep 6, 2024
1 parent bad9e6a commit 9bfd340
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion docs/build/identity.rs/1.3/docs/references/.gitignore
View file
Original file line number Diff line number Diff line change
@@ -1 +1 @@
wasm
wasm
6 changes: 3 additions & 3 deletions ...ld/identity.rs/1.3/docs/references/specifications/revocation-timeframe-2024.mdx
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ For an issuer to enable verifiers to check the status of a verifiable credential

| Property | Description |
| :---------------------- | :--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| `id` | The constraints on the `id` property are listed in the [Verifiable Credentials Data Model specification](https://www.w3.org/TR/vc-data-model/). The `id` MUST be a [DID URL](https://www.w3.org/TR/did-core/#did-url-syntax) that is the URL to a [Revocation Bitmap Service](#revocation-timeframe-service) in the DID Document of the issuer. |
| `id` | The constraints on the `id` property are listed in the [Verifiable Credentials Data Model specification](https://www.w3.org/TR/vc-data-model/). The `id` MUST be a [DID URL](https://www.w3.org/TR/did-core/#did-url-syntax) that is the URL to a [Revocation Timeframe Service](#revocation-timeframe-service) in the DID Document of the issuer. |
| `type` | The `type` property MUST be `"RevocationTimeframe2024"`. |
| `revocationBitmapIndex` | The `revocationBitmapIndex` property MUST be an unsigned, 32-bit integer expressed as a string. This is the index of the credential in the issuers revocation bitmap. Each index SHOULD be unique among all credentials linking to the same [Revocation Bitmap Service](#revocation-timeframe-service). To ensure user unlinkability, this value MUST NOT be disclosed to the verifier (this is done by default). |
| `revocationBitmapIndex` | The `revocationBitmapIndex` property MUST be an unsigned, 32-bit integer expressed as a string. This is the index of the credential in the issuers revocation bitmap. Each index SHOULD be unique among all credentials linking to the same [Revocation Timeframe Service](#revocation-timeframe-service). To ensure user unlinkability, this value MUST NOT be disclosed to the verifier (this is done by default). |
| `startValidityTimeframe`| The `startValidityTimeframe` property MUST be a [RFC 3339](https://datatracker.ietf.org/doc/html/rfc3339)-compliant timestamp. |
| `endValidityTimeframe`| The `endValidityTimeframe` property MUST be a [RFC 3339](https://datatracker.ietf.org/doc/html/rfc3339)-compliant timestamp. |

Expand Down Expand Up @@ -98,7 +98,7 @@ To allow verifiers to check the status of a [Revocation Timeframe Status](#revoc
| :---------------- | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| `id` | The constraints on the `id` property are listed in the [DID Core service specification](https://www.w3.org/TR/did-core/#services). The `id` property MUST be a DID URL uniquely identifying the revocation bitmap. |
| `type` | The `type` property MUST be `"RevocationTimeframe2024"`. |
| `serviceEndpoint` | The `serviceEndpoint` MUST be generated according to the service endpoint generation algorithm. |
| `serviceEndpoint` | The `serviceEndpoint` MUST be generated according to the service endpoint generation algorithm described in [`RevocationBitmap2022`](revocation-bitmap-2022.mdx#service-endpoint-generation-algorithm). |

#### Example

Expand Down
3 changes: 2 additions & 1 deletion scripts/get_identity_references.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,5 @@

# Return to root and cleanup
cd -
rm -rf tmp
rm -rf tmp

0 comments on commit 9bfd340

Please sign in to comment.