Merge pull request #847 from iotaledger/mempool-invalid-signature-tes…

…t-docker

Add docker mempool invalid signatures test

pkg/tests/mempool_invalid_signatures_test.go

@@ -32,7 +32,7 @@ func Test_MempoolInvalidSignatures(t *testing.T) {
 	validTX := wallet.CreateBasicOutputsEquallyFromInput("TX", 1, "Genesis:0")
 	invalidTX := validTX.Clone().(*iotago.SignedTransaction)
 
-	// Make tx3 invalid by replacing the first unlock with an empty signature unlock.
+	// Make validTX invalid by replacing the first unlock with an empty signature unlock.
 	_, is := invalidTX.Unlocks[0].(*iotago.SignatureUnlock)
 	if !is {
 		panic("expected signature unlock as first unlock")

tools/docker-network/.env

@@ -2,6 +2,7 @@ COMMON_CONFIG="
 -c config.json
 --logger.level=debug
 --logger.outputPaths=stdout
+--retainer.debugStoreErrorMessages=true
 --p2p.db.path=/app/data/peerdb
 --profiling.enabled=true
 --profiling.bindAddress=0.0.0.0:6061

tools/docker-network/tests/mempool_invalid_signatures_test.go

@@ -0,0 +1,69 @@
+//go:build dockertests
+
+package tests
+
+import (
+	"context"
+	"fmt"
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/require"
+
+	iotago "github.com/iotaledger/iota.go/v4"
+	"github.com/iotaledger/iota.go/v4/api"
+)
+
+func Test_MempoolInvalidSignatures(t *testing.T) {
+	d := NewDockerTestFramework(t,
+		WithProtocolParametersOptions(
+			iotago.WithTimeProviderOptions(5, time.Now().Unix(), 10, 4),
+			iotago.WithLivenessOptions(10, 10, 2, 4, 8),
+			iotago.WithRewardsOptions(8, 10, 2, 384),
+			iotago.WithTargetCommitteeSize(4),
+		))
+	defer d.Stop()
+
+	d.AddValidatorNode("V1", "docker-network-inx-validator-1-1", "http://localhost:8050", "rms1pzg8cqhfxqhq7pt37y8cs4v5u4kcc48lquy2k73ehsdhf5ukhya3y5rx2w6")
+	d.AddValidatorNode("V2", "docker-network-inx-validator-2-1", "http://localhost:8060", "rms1pqm4xk8e9ny5w5rxjkvtp249tfhlwvcshyr3pc0665jvp7g3hc875k538hl")
+	d.AddValidatorNode("V3", "docker-network-inx-validator-3-1", "http://localhost:8070", "rms1pp4wuuz0y42caz48vv876qfpmffswsvg40zz8v79sy8cp0jfxm4kunflcgt")
+	d.AddValidatorNode("V4", "docker-network-inx-validator-4-1", "http://localhost:8040", "rms1pr8cxs3dzu9xh4cduff4dd4cxdthpjkpwmz2244f75m0urslrsvtsshrrjw")
+	d.AddNode("node5", "docker-network-node-5-1", "http://localhost:8090")
+
+	err := d.Run()
+	require.NoError(t, err)
+
+	d.WaitUntilNetworkReady()
+
+	account := d.CreateAccount()
+
+	ctx := context.Background()
+	fundsOutputID := d.RequestFaucetFunds(ctx, iotago.AddressEd25519)
+	input := d.wallet.Output(fundsOutputID)
+	validTX := d.wallet.CreateBasicOutputFromInput(input, account.ID)
+	invalidTX := validTX.Clone().(*iotago.SignedTransaction)
+
+	// Make validTX invalid by replacing the first unlock with an empty signature unlock.
+	_, is := invalidTX.Unlocks[0].(*iotago.SignatureUnlock)
+	require.Truef(t, is, "expected signature unlock as first unlock")
+	invalidTX.Unlocks[0] = &iotago.SignatureUnlock{
+		Signature: &iotago.Ed25519Signature{},
+	}
+
+	fmt.Println("Submitting block with invalid TX")
+	issuerResp, congestionResp := d.PrepareBlockIssuance(ctx, d.wallet.DefaultClient(), account.ID.ToAddress().(*iotago.AccountAddress))
+	d.SubmitPayload(context.Background(), invalidTX, account.ID, congestionResp, issuerResp)
+
+	d.AwaitTransactionState(ctx, invalidTX.Transaction.MustID(), api.TransactionStateFailed)
+	d.AwaitTransactionFailure(ctx, invalidTX.Transaction.MustID(), api.TxFailureUnlockSignatureInvalid)
+
+	fmt.Println("Submitting block with valid TX")
+	issuerResp, congestionResp = d.PrepareBlockIssuance(ctx, d.wallet.DefaultClient(), account.ID.ToAddress().(*iotago.AccountAddress))
+	d.SubmitPayload(context.Background(), validTX, account.ID, congestionResp, issuerResp)
+
+	fmt.Println("Submitting block with invalid TX (again)")
+	issuerResp, congestionResp = d.PrepareBlockIssuance(ctx, d.wallet.DefaultClient(), account.ID.ToAddress().(*iotago.AccountAddress))
+	d.SubmitPayload(context.Background(), invalidTX, account.ID, congestionResp, issuerResp)
+
+	d.AwaitTransactionPayloadAccepted(ctx, validTX.Transaction.MustID())
+}

tools/docker-network/tests/utils.go

@@ -214,6 +214,40 @@ func (d *DockerTestFramework) AwaitTransactionPayloadAccepted(ctx context.Contex
 	})
 }
 
+func (d *DockerTestFramework) AwaitTransactionState(ctx context.Context, txID iotago.TransactionID, expectedState api.TransactionState) {
+	clt := d.wallet.DefaultClient()
+
+	d.Eventually(func() error {
+		resp, err := clt.TransactionMetadata(ctx, txID)
+		if err != nil {
+			return err
+		}
+
+		if expectedState == resp.TransactionState {
+			return nil
+		} else {
+			return ierrors.Errorf("expected transaction %s to have state %s, got %s instead", txID, expectedState, resp.TransactionState)
+		}
+	})
+}
+
+func (d *DockerTestFramework) AwaitTransactionFailure(ctx context.Context, txID iotago.TransactionID, expectedReason api.TransactionFailureReason) {
+	clt := d.wallet.DefaultClient()
+
+	d.Eventually(func() error {
+		resp, err := clt.TransactionMetadata(ctx, txID)
+		if err != nil {
+			return err
+		}
+
+		if expectedReason == resp.TransactionFailureReason {
+			return nil
+		} else {
+			return ierrors.Errorf("expected transaction %s to have failure reason %T, got %s instead, failure details: %s", txID, expectedReason, resp.TransactionState, resp.TransactionFailureDetails)
+		}
+	})
+}
+
 func (d *DockerTestFramework) AwaitCommitment(targetSlot iotago.SlotIndex) {
 	currentCommittedSlot := d.NodeStatus("V1").LatestCommitmentID.Slot()