Merge pull request #853 from iotaledger/chore/fix-linter-issues

Adapt .golangci.yml to latest version

.golangci.yml

@@ -1,10 +1,5 @@
 run:
     tests: true
-    skip-dirs:
-        - components/dashboard
-    skip-files:
-        - ".*_test.go$"
-        - "testframework.go"
 
 linters-settings:
     gofmt:
@@ -14,7 +9,8 @@ linters-settings:
     gocyclo:
         min-complexity: 15
     govet:
-        check-shadowing: false
+       disable:
+          - shadow
     misspell:
         locale: US
     staticcheck:
@@ -56,7 +52,7 @@ linters:
         - bidichk
         - bodyclose
         #- containedctx
-        - contextcheck
+        #- contextcheck     # this linter is buggy and renders all nolint rules useless
         - decorder
         - depguard
         - dogsled
@@ -115,6 +111,12 @@ linters:
         #- varnamelen
 
 issues:
+    exclude-dirs:
+        - components/dashboard
+    exclude-files:
+        - ".*_test.go$"
+        - "testframework.go"
+        - ".*.pb.go$"
     # Maximum issues count per one linter.
     # Set to 0 to disable.
     # Default: 50

pkg/testsuite/transactions.go

@@ -28,7 +28,7 @@ func (t *TestSuite) AssertTransaction(transaction *iotago.Transaction, node *moc
 			return ierrors.Errorf("AssertTransaction: %s: expected ID %s, got %s", node.Name, transactionID, loadedTransactionMetadata.ID())
 		}
 
-		// nolint: forcetypeassert // we are in a test and want to assert it anyway
+		//nolint:forcetypeassert // we are in a test and want to assert it anyway
 		if !assert.Equal(t.fakeTesting, transaction.TransactionEssence, loadedTransactionMetadata.Transaction().(*iotago.Transaction).TransactionEssence) {
 			return ierrors.Errorf("AssertTransaction: %s: expected TransactionEssence %v, got %v", node.Name, transaction.TransactionEssence, loadedTransactionMetadata.Transaction().(*iotago.Transaction).TransactionEssence)
 		}