Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: issue a block with a native token #8298

Merged
merged 5 commits into from
Apr 4, 2024
Merged

feat: issue a block with a native token #8298

merged 5 commits into from
Apr 4, 2024

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented Apr 3, 2024

Closes #7977

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 linked an issue Apr 3, 2024 that may be closed by this pull request
[Task]: Succesfully issue a block with a native token tx #7977
Closed
@cpl121 cpl121 changed the title feat: issue a block with a native token WIP feat: issue a block with a native token Apr 3, 2024
@cpl121 cpl121 marked this pull request as ready for review April 3, 2024 16:37
@cpl121 cpl121 requested review from marc2332 and evavirseda April 3, 2024 16:37
begonaalvarezd
begonaalvarezd approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

begonaalvarezd
begonaalvarezd requested changes Apr 3, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test fails, we should fix or ignore 🙏🏼

@cpl121 cpl121 requested a review from begonaalvarezd April 3, 2024 21:48
evavirseda
evavirseda approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works 🚀

@begonaalvarezd begonaalvarezd merged commit 6a63529 into develop-iota2.0 Apr 4, 2024
3 of 4 checks passed
@begonaalvarezd begonaalvarezd deleted the feat/issue-a-block-with-a-native-token branch April 4, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evavirseda evavirseda evavirseda approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

@marc2332 marc2332 Awaiting requested review from marc2332

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Succesfully issue a block with a native token tx
3 participants
@cpl121 @begonaalvarezd @evavirseda