-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: cleanup AccountInput
and remove RecipientAccountSelector
#7186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure we want to remove this component, it looks like a good reusable component to me, even though its only used once, it might be able to be used later on. Perhaps what we could do is call it like AccountSelector or AccountInputSelector or something like that because its not really an input, wdyt?
AccountInput
AccountInput
and remove RecipientAccountSelector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Fixes #7172
Fixes #7268
RecipientAccountSelector
andAccountInput
into a single componentAccountInput
toAccountSelector
...
Changelog
Testing
Platforms
Instructions
...
Checklist