Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup AccountInput and remove RecipientAccountSelector #7186

Merged
merged 11 commits into from
Aug 20, 2023

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented Jul 13, 2023

Summary

Fixes #7172
Fixes #7268

  • Unify RecipientAccountSelector and AccountInput into a single component
  • Rename AccountInput to AccountSelector

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@VmMad VmMad added the type:refactor Refactor code label Jul 13, 2023
Copy link
Collaborator

@evavirseda evavirseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure we want to remove this component, it looks like a good reusable component to me, even though its only used once, it might be able to be used later on. Perhaps what we could do is call it like AccountSelector or AccountInputSelector or something like that because its not really an input, wdyt?

@VmMad VmMad changed the title refactor: remove component AccountInput refactor: cleanup AccountInput and remove RecipientAccountSelector Jul 25, 2023
Copy link
Member

@cpl121 cpl121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been interesting clean it up so the modal component ends up being reusable for other places, atm we have it for deep links and the send flow, and its practically the same modal, just the information displayed differs a bit.

image
image

But for now I think its ok

@begonaalvarezd begonaalvarezd merged commit e16ed70 into develop Aug 20, 2023
4 checks passed
@begonaalvarezd begonaalvarezd deleted the refactor/components/AccountInput branch August 20, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Remove RecipientAccountSelector [Task]: Cleanup AccountInput
4 participants